Commit
fix(library): fix Popover initialization in LibrarySearchFilter causing page load failure
Commit details
Commit notes
The LibrarySearchFilter component was using an incorrect Popover initialization pattern that caused the library page not to load:
1. Variable declaration order issue: filterOpen variable was declared AFTER being referenced in the Popover constructor (temporal dead zone issue)
2. Wrong Popover pattern: The component used custom open/onOpenChange callbacks and getter functions for floatingConfig, which differs from the simple pattern used in all other working components
Fixed by: - Removing the custom open/onOpenChange callbacks from Popover constructor - Using floatingConfig as a plain object instead of a getter function - Using filterPopover.open directly instead of separate filterOpen state - Matching the pattern used in WorkspaceSwitcher, Header, and other components
Co-authored-by: armin.naimi <[email redacted]>
- Files changed
- 1
- Lines added
- +5
- Lines removed
- −10